Fix Migration#reversible by not using transaction.
#8588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix Migration#reversible by not using `transaction`. * Adapt mysql adapter to updated api for remove_column * Update test after aedcd68
|
Updated, should address all failures. Sorry for these issues. I somehow didn't realize I was only testing using sqlite... Also for some reason I was sure that travis was running on pull requests too. |
|
Travis doesn't run on PRs for rails, we're super intense on resources at the moment. |
Merged
carlosantoniodasilva
added a commit
that referenced
this pull request
Dec 23, 2012
Fix Migration#reversible by not using `transaction`.
|
Thanks @marcandre. Lets get travis running this so :) |
|
Great, mysql seems to be fine. Railties tests haven't run though, lets wait for some other commit to get them running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing trouble in mysql/mysql2 because transactions
are not supported when modifying schema. [#8267]
@carlosantoniodasilva There are other failures to fix, but my PB is running out of juice, so I'll handle those later today.